[Orxonox-commit 3592] r8277 - code/branches/kicklib/cmake

[rgrieder at orxonox.net]

Author: rgrieder
Date: 2011-04-20 20:49:58 +0200 (Wed, 20 Apr 2011)
New Revision: 8277

Modified:
   code/branches/kicklib/cmake/CompilerConfigMSVC.cmake
Log:
That was a tricky one: for Orxonox, STL iterator checking was explicitly disabled for release builds with MSVC. Now it turns out that this actually changes the std::vector class, so that it cannot be shared across boundaries where the iterator checking setting is different. And Ogre compiles with the default behaviour, so iterator checking was enabled, even for release builds (MSVC 8 and 9, not 10). This caused Orxonox to crash completely in release builds with MSVC 8 and 9.
Resolution: revert to the standard behaviour (always enabled for MSVC 8/9 and only enabled for debug builds in MSVC 10). The performance shouldn't really degrade at all. Also, for deployment, we're not going to use MSVC 8 and 9 anymore anyway after kicklib merging.

Modified: code/branches/kicklib/cmake/CompilerConfigMSVC.cmake
===================================================================
--- code/branches/kicklib/cmake/CompilerConfigMSVC.cmake	2011-04-20 17:43:23 UTC (rev 8276)
+++ code/branches/kicklib/cmake/CompilerConfigMSVC.cmake	2011-04-20 18:49:58 UTC (rev 8277)
@@ -68,9 +68,6 @@
 # Note: It hasn't been checked yet whether we have code that might break
 #ADD_COMPILER_FLAGS("-fp:fast" CACHE)
 
-# No iterator checking for release builds (MSVC 8 dosn't understand this though)
-ADD_COMPILER_FLAGS("-D_SECURE_SCL=0" ReleaseAll CACHE)
-
 # Newer MSVC versions come with std::shared_ptr which conflicts with
 # boost::shared_ptr in cpptcl. And since we don't yet use the new C++ standard
 # anyway, disable it completely.